Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove upgrade of wheel #2542

Merged
merged 2 commits into from
Sep 19, 2024
Merged

ci: Remove upgrade of wheel #2542

merged 2 commits into from
Sep 19, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 19, 2024

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove upgrading of wheel from CI workflows.
   - For dependencies that don't provide a wheel, and don't have build-system
     metadata in pyproject.toml, modern setuptools has integrated wheel and so
     installation is unnecessary.
* Remove 'uv pip install --system --upgrade pip' as 'uv pip' is a different
  program.

* Remove upgrading of wheel from CI workflows.
   - For dependencies that don't provide a wheel, and don't have build-system
     metadata in pyproject.toml, modern setuptools has integrated wheel and so
     installation is unnecessary.
* Remove 'uv pip install --system --upgrade pip' as 'uv pip' is a different
  program.
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Sep 19, 2024
@matthewfeickert matthewfeickert self-assigned this Sep 19, 2024
@matthewfeickert matthewfeickert added the Docker Involving Docker images or builds label Sep 19, 2024
@matthewfeickert matthewfeickert enabled auto-merge (squash) September 19, 2024 16:30
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (aab3468) to head (8a1a7ae).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2542   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 609af88 into main Sep 19, 2024
22 of 23 checks passed
@matthewfeickert matthewfeickert deleted the ci/remove-wheel-install branch September 19, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions Docker Involving Docker images or builds
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant